Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade minimum ruby version to 2.7 #86

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Upgrade minimum ruby version to 2.7 #86

merged 2 commits into from
Jan 16, 2023

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Jan 12, 2023 •
edited
Loading

Purpose

  • Maintenance
  • Preparation for upgrading to ruby 3.0

Overview

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@yuokada yuokada requested a review from a team as a code owner January 12, 2023 08:40
miniway
miniway approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@miniway miniway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuokada yuokada merged commit 07921fd into master Jan 16, 2023
@yuokada yuokada deleted the upgrade-minimum-1 branch February 2, 2023 03:37
@exoego exoego added chore non user-facing trivial stuff (CI, refactoring, etc) enhancement and removed chore non user-facing trivial stuff (CI, refactoring, etc) labels Feb 22, 2023
@yuokada yuokada mentioned this pull request Feb 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniway miniway miniway approved these changes

@takezoe takezoe Awaiting requested review from takezoe

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuokada @miniway @exoego