Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] multiple small corrections & unifications. pylint findings, logging, comments, unittests #107

Merged
merged 6 commits into from
Apr 19, 2022
Merged

[DEV] multiple small corrections & unifications. pylint findings, logging, comments, unittests #107

merged 6 commits into from
Apr 19, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 12, 2022 •
edited
Loading

This PR…

  • includes multiple small corrections & unifications:
    • pylint findings
    • logging
    • comments
    • unittests
    • refactor .osm.pbf downloading

Considerations and implementations

How to test

  1. run unittests
  2. open GUI

Pull Request Checklist

@treee111 treee111 changed the title [DEV] multiple small corrections & unification correct pylint findings [DEV] multiple small corrections & unifications. pylint findings, logging, comments, unittests Apr 12, 2022
@treee111 treee111 marked this pull request as ready for review April 12, 2022 14:32
@treee111 treee111 force-pushed the different-corrections branch from 156a387 to 4d7c475 Compare April 12, 2022 15:51
@treee111 treee111 force-pushed the different-corrections branch from 4d7c475 to b1bb5b1 Compare April 19, 2022 20:20
@treee111 treee111 force-pushed the different-corrections branch from b1bb5b1 to 9a94017 Compare April 19, 2022 20:24
treee111 added 6 commits April 19, 2022 22:34
@treee111
adjust config for unittest & delete .dbf files
70c70ea 
- .dbf files are always different. If the file is deleted it will not be compared in unittest
@treee111
refactor logging output to be consistent with #/+
74a0e7e
@treee111
only process countries which are involved in the tile
3613c38 
- in merge_splitted_tiles_with_land_and_sea() the other ones are note included as well!
@treee111
refactor .osm.pbf file download
60f3c86 
- adjust unittests + add new constant unittests
@treee111
launch-config: STG->gardasee
4ed7058
@treee111
correct pylint findings
07a9208 
- specific exceptions
- specific encoding
- unittests for the changes above
- unified pylint disablement
@treee111 treee111 force-pushed the different-corrections branch from 9a94017 to 07a9208 Compare April 19, 2022 20:35
@treee111 treee111 merged commit c8ecf44 into develop Apr 19, 2022
@treee111 treee111 deleted the different-corrections branch April 19, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@treee111