Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] correct pylint findings #116

Merged
merged 5 commits into from
May 2, 2022
Merged

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented May 2, 2022

This PR…

  • corrects all pylint findings
  • changes the needed pylint score to 10/10

Considerations and implementations

follow-up on #103

How to test

  1. Run unittests
  2. Run GUI and process maps
  3. Process maps via CLI

Pull Request Checklist

treee111 added 2 commits May 3, 2022 01:17
in test_constants and constants that is intended
@treee111 treee111 force-pushed the fix-pylint-findings branch from cbcd7ed to 2885465 Compare May 2, 2022 23:21
@treee111 treee111 changed the base branch from develop to release-v2.0.0 May 2, 2022 23:22
@treee111 treee111 merged commit d85bd01 into release-v2.0.0 May 2, 2022
@treee111 treee111 deleted the fix-pylint-findings branch May 2, 2022 23:22
treee111 added a commit that referenced this pull request May 6, 2022
* [DEV] Change structure of repository to python module (#115)

* move main file to common_python folder. callable with -m

- "python -m common_python cli -co malta"

* rename common_python folder to wahoo_mc

* move /common_resources content to /wahoo_mc/resources

- incl. introducing and adjusting constants

* change stuff to wahoo_mc

- wahoo_maps_creator.py --> wahoo_mc
- common_python --> wahoo_mc
- pylint findings
- adjust copy script

* update documentation

* move /tooling_windows content to /wahoo_mc/tooling_win

- incl. adjusting constants

* rename wahoo_map_creator.py to main.py

* [DEV] correct pylint findings (#116)

* fix pylint findings

* fix last bit pylint findings --> 10/10!

* adjust pylint check to need a score of 10/10

* do not check for duplicate code

in test_constants and constants that is intended

* install imported modules

* disable zipping in default. provide CLI option

* GUI option for zipping output folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant