Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] Fix unittest, add v3 to v4 migration to FAQ, delete unused class attribute (seen during implementation of release v4.0.0) #180

Merged
merged 3 commits into from
Feb 19, 2023
Merged

[DEV] Fix unittest, add v3 to v4 migration to FAQ, delete unused class attribute (seen during implementation of release v4.0.0) #180

merged 3 commits into from
Feb 19, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Feb 17, 2023 •
edited
Loading

This PR…

  • makes a unittest run successful again
  • deletes a unused class attribute
  • add v3 to v4 migration to FAQ.md

How to test

  1. ...
  2. ...

Pull Request Checklist

@treee111 treee111 changed the base branch from develop to release-v4.0.0 February 17, 2023 06:36
@treee111 treee111 changed the title [DEV] Fix unittest [DEV] Fix unittest and other small corrections during implementation of release v4.0.0 Feb 19, 2023
@treee111 treee111 marked this pull request as ready for review February 19, 2023 13:31
@treee111 treee111 changed the title [DEV] Fix unittest and other small corrections during implementation of release v4.0.0 [DEV] Fix unittest, delete unused class instance, add v3 to v4 migration to FAQ, (occured during implementation of release v4.0.0) Feb 19, 2023
@treee111 treee111 changed the title [DEV] Fix unittest, delete unused class instance, add v3 to v4 migration to FAQ, (occured during implementation of release v4.0.0) [DEV] Fix unittest, delete unused class attribute, add v3 to v4 migration to FAQ, (occured during implementation of release v4.0.0) Feb 19, 2023
@treee111 treee111 changed the title [DEV] Fix unittest, delete unused class attribute, add v3 to v4 migration to FAQ, (occured during implementation of release v4.0.0) [DEV] Fix unittest, add v3 to v4 migration to FAQ, delete unused class attribute (seen during implementation of release v4.0.0) Feb 19, 2023
@treee111 treee111 added documentation Improvements or additions to documentation refactoring labels Feb 19, 2023
@treee111 treee111 merged commit 99ed025 into release-v4.0.0 Feb 19, 2023
@treee111 treee111 deleted the fix-unittest branch February 19, 2023 20:18
treee111 added a commit that referenced this pull request May 5, 2023
@treee111
[DEV] Fix unittest, add v3 to v4 migration to FAQ, delete unused clas…
acdac93 
…s attribute (seen during implementation of release v4.0.0) (#180)

* fix unittest

* variable is not used

* FAQ: migrate from v3.x.x to v4.x.x
alfh pushed a commit to alfh/wahooMapsCreator that referenced this pull request Nov 4, 2023
@treee111 @alfh
[DEV] Fix unittest, add v3 to v4 migration to FAQ, delete unused clas…
9873c4e 
…s attribute (seen during implementation of release v4.0.0) (treee111#180)

* fix unittest

* variable is not used

* FAQ: migrate from v3.x.x to v4.x.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@treee111