[DEV] refactor coding: do/remove checks, adjust exceptions, cleanup coding #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treee111
changed the title
with unittests
- nowadays input is checked against geofabrik countries - countries are translated in addition when initializing class CountryGeofabrik
treee111
force-pushed
the
exceptions-cleanup-2
branch
from
174d0a2 to
da48a2b
Compare
treee111
changed the title
treee111
added a commit
that referenced
this pull request
May 5, 2023
…oding (#196) * move get_ ... _from_input to each class as static method * move translate_id_no_to_geofabrik to CountryGeofabrik with unittests * check if xy coordinate has countries and exit if not with unittests * delete unused functions. found with vulture * unify docs * remove not needed translations from input country to geofabrik country - nowadays input is checked against geofabrik countries - countries are translated in addition when initializing class CountryGeofabrik
alfh
pushed a commit
to alfh/wahooMapsCreator
that referenced
this pull request
Nov 4, 2023
…oding (treee111#196) * move get_ ... _from_input to each class as static method * move translate_id_no_to_geofabrik to CountryGeofabrik with unittests * check if xy coordinate has countries and exit if not with unittests * delete unused functions. found with vulture * unify docs * remove not needed translations from input country to geofabrik country - nowadays input is checked against geofabrik countries - countries are translated in addition when initializing class CountryGeofabrik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
a simple, one sentence summary of the ticket ensures the PR has a clear overall focus.
How to test
Pull Request Checklist