Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] copy version files to each tile folder of map archive (relevant when having >2 tiles) #92

Merged

Conversation

mweirauch
Copy link
Contributor

@mweirauch mweirauch commented Jan 25, 2022

This PR…

Fixes copying the version files to the map archive.

How to test

  1. look for version files (currently .12 in the country-zip)

Pull Request Checklist

Wrong Indentation. (Must be in the for-loop.)

Also updated some wording and added exception logging.
@treee111 treee111 changed the title [FIX] copy version files to map archive [FIX] copy version files to each tile folder of map archive (relevant when having >2 tiles) Jan 26, 2022
Copy link
Owner

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice finding! thanks for the fix 👍

took me some time to realize that your fix only takes effekt when having > 1 tile^^
worked too long today...

I think you are good with having this merged or should I release a new version?

@treee111 treee111 merged commit e50c1b7 into treee111:develop Jan 26, 2022
@mweirauch mweirauch deleted the fix-copy-version-files-to-map-archive branch January 26, 2022 21:17
@mweirauch
Copy link
Contributor Author

Thanks for merging. Yes, it basically only copied the last tile to which src and dst where still pointing to. Should have mentioned that.

And no, no new release required from my side. Always working/using from develop.

@treee111 treee111 added this to the v1.1.0 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants