Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self signed certificate #67

Closed
Techno-Fox opened this issue Feb 18, 2022 · 9 comments
Closed

self signed certificate #67

Techno-Fox opened this issue Feb 18, 2022 · 9 comments

Comments

@Techno-Fox
Copy link
Contributor

Thank you for making an easy http/https library for Nim. I wanted to know how would I be able to use a self signed certificate for https. When ever I try it, it gives me the error.

"SSL peer certificate or SSH remote key was not OK"

@treeform
Copy link
Owner

We don't support self signed certs at the moment. We don't have a need for this so we will probably not add it. Sorry! PRs welcome though.

I recommend going with Let's Encrypt (totally free) or CloudFlare (free tear) for real SSL certs. I use both.

@Techno-Fox
Copy link
Contributor Author

Working on it now.

@Techno-Fox
Copy link
Contributor Author

I've already got the windows, and curl. Working on the macos. I don't have experience with macos, so this one might take a bit.

@Techno-Fox
Copy link
Contributor Author

I'm having some issues with the macos side of things. Given my little to no experience with macos, it would make sense. How would you allow insecure certificates on a NSMutableURLRequest. I've tried using setAllowsAnyHTTPSCertificate as

proc setAllowsAnyHTTPSCertificate*(self: NSMutableURLRequest)

however then I'm getting NSInvalidArgumentException.

@treeform
Copy link
Owner

Add a draft pr and we will take a look.

@Techno-Fox
Copy link
Contributor Author

I've sent it.

@drighty
Copy link

drighty commented Oct 12, 2022

see pull request #84, is it related?

@guzba
Copy link
Collaborator

guzba commented Dec 7, 2022

Related previous PR: #68

@treeform
Copy link
Owner

treeform commented Dec 8, 2022

This should be good to go in puppy 1.6.1. Let us know if you still have issues with this.

@treeform treeform closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants