Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose templates for generating procedures and operators #61

Open
SMT50001 opened this issue Dec 11, 2022 · 7 comments
Open

Expose templates for generating procedures and operators #61

SMT50001 opened this issue Dec 11, 2022 · 7 comments

Comments

@SMT50001
Copy link
Contributor

SMT50001 commented Dec 11, 2022

Could you please expose genConstructor, genMatConstructor, genQuatConstructor to library user? For example I would like to write a library for fixed point arithmetic and use my new datatypes with vmath, but I'll need to write these templates again.

@SMT50001
Copy link
Contributor Author

General ideas on exposing this interface to users. Maybe it will be a good idea to rename genConstructor to genVecConstructor to avoid name clash. Also it will be nice to remove the need to explicitly write constructor names which are type names in lowercase anyway.

@treeform
Copy link
Owner

renaming genConstructor to genVecConstructor is a good idea

@SMT50001
Copy link
Contributor Author

Maybe I should make a commit with fixed point arithmetic to vmath instead of exposing templates?

@SMT50001
Copy link
Contributor Author

@treeform Should I add fixed-point math to the library instead of making those templates available? If so, I'll just make a pull-request and close this issue.

@treeform
Copy link
Owner

treeform commented Mar 4, 2023

Do you have a link to your fixed-point math lib? I want to test to see if it works with the new genVecConstructor.

@SMT50001
Copy link
Contributor Author

SMT50001 commented Mar 5, 2023

Sorry, I don't have a link. My intention was to write the code as soon as necessary changes were made to vmath.

@SMT50001
Copy link
Contributor Author

@treeform What should I add for it being able to be tested? https://gist.github.com/SMT50001/9998844c15a6e5ade5aa43dfa78ba592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants