Skip to content
This repository has been archived by the owner on Feb 13, 2020. It is now read-only.

Catch throwables / reschedule or bury #16

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

mikemeier
Copy link
Contributor

If a fatal error occurs on a worker, this code will not catch the exception. Use \Throwable for also reschedule or bury jobs with fatal aborts in executor.

If a fatal error occurs on a worker, this code will not catch the exception. Use \Throwable for also reschedule or bury jobs with fatal aborts in executor.
@pkruithof
Copy link
Contributor

Thanks, can you also write a test for this?

@mikemeier
Copy link
Contributor Author

@pkruithof Added tests

@mikemeier
Copy link
Contributor Author

@pkruithof ping
you should drop support of old php versions but merge instead pls :-)

@pkruithof
Copy link
Contributor

Sounds reasonable, though that would be a major version change, which is fine by me. I'll have to update the Travis build matrix first.

@pkruithof pkruithof merged commit a3d6a18 into treehouselabs:master Jan 29, 2019
@mikemeier mikemeier deleted the patch-1 branch January 29, 2019 13:38
@mikemeier
Copy link
Contributor Author

@pkruithof wow super cool, let me know when a tag exists, so we can use it right away, thanks!

@pkruithof
Copy link
Contributor

I just released 2.0, which contains this PR, and drops support for old php/symfony versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants