[Bug]: UI Markdown Renderer not using presign URL to get images

[Isan-Rivkin]

What happened?

What

When rendering Markdown files, the UI loads images.
The problem is that when getting those images from lakeFS the UI ignores presign config (i.e sample repository, sample data in a custom repository or just any custom Markdown that fetches files from lakefs://).

Why

Those images are rendered in CustomMarkdownRenderer component which in turns uses imageUriReplacer to fetch the images to load. The request to download the image doesn't use presign hence downloading directly from lakeFS server.

Impact

Besides the unexpected behavior and the extra work lakeFS server does + extra cost it's breaking in case the storage credentials (S3,GCS,AZ) does not allow lakeFS server directly to get objects then the Markdown rendering breaks.

Steps to Reproduce:

1. Setup lakeFS server with S3 and all the IAM permissions for using pre-sign from lakeFS
2. Configure the UI to use presign:

blockstore:
  type: s3
  s3:
    disable_pre_signed_ui: false
    disable_pre_signed: false

4. Create a repository > Select Add sample data, hooks, and configuration
5. In the browser network tab see many GET requests for resources that does not specify presign: true. (i.e /api/v1/repositories/first1/refs/main/objects?path=images%2Fcreate-lakefs-branch.png)

Expected behavior

• Markdown renderer in the UI to include presign flag and respect it when downloading images.
• The Markdown to render correctly even if lakeFS is not allowed to do Get directly.

lakeFS version

v0.105.0

How lakeFS is installed

locally

Affected clients

ui

Relevant log output

level=error msg="failed to get S3 object bucket my-bucket/remote/first1 key data/1234567/11122324123" func="pkg/logging.(*logrusEntryWrapper).Errorf" file="build/pkg/logging/logger.go:285" error="AccessDenied: Access Denied\n\tstatus code: 403, request id: 123, host id: ..." host=lakefs-presign.us-east-1.lakefscloud.ninja method=GET operation=GetObject operation_id=GetObject path="/api/v1/repositories/first1/refs/main/objects?path=images%2Fhooks-07.png" request_id=... service_name=rest_api user=admin

Contact details

No response

[github-actions]

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

[github-actions]

Closing this issue because it has been stale for 7 days with no activity.