Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance UI tests to replace manual quickstart run when releasing OSS #7973

Closed
yonipeleg33 opened this issue Jul 9, 2024 · 3 comments · Fixed by #8012
Closed

Enhance UI tests to replace manual quickstart run when releasing OSS #7973

yonipeleg33 opened this issue Jul 9, 2024 · 3 comments · Fixed by #8012
Assignees

Comments

@yonipeleg33
Copy link
Contributor

yonipeleg33 commented Jul 9, 2024

Follow up on #7964

For context, see this comment on the design proposal PR.

Definition of done

We feel confident enough in the tests and CI that we don't need to manually run lakefs with --quickstart when releasing OSS.

Current state

We have a minimal Playwright test suite that runs as part of the CI.
FWICT, the test suite runs against DynamoDB kv store and local block store, and covers the setup page, repositories page, and querying an object:

$ tree webui/test/e2e/common                            
webui/test/e2e/common
├── README.md
├── readOnlyRepository.spec.ts
├── repositoriesPage.spec.ts
├── setup.spec.ts
└── viewParquetObject.spec.ts

Tasks

  1. Add tests or create a new test suite that covers at least "Query"( ✔️ ), "Branch"(❌), "Merge"(❌), and "Rollback"(❌) flows from the quickstart guide
  2. Run them as part of the CI, in one of the following points:
    • As part of the goreleaser job - this is the minimal required frequency for running these tests.
    • On push to master - this ensures "releasability" of the master branch at any point in time.
    • On push to every branch (part of the CI job) - a bit excessive IMO, but a valid option as long as it doesn't become a bottleneck in the CI.
@Isan-Rivkin
Copy link
Contributor

@yonipeleg33 Im a bit confused by this task definitions.

  1. Why do we need additional test to use --quickstart flag? Since currently the e2e tests only difference is using dynamodb container.
  2. Is the current Playwright provide coverage for quickstart? in terms of functionality that we test or tests need to be added?
  3. Please clarify - what should be the deliverable of this task? a standalone ci job? part of some other workflow?

@yonipeleg33
Copy link
Contributor Author

@Isan-Rivkin good points, I have updated the description as we discussed privately

@yonipeleg33 yonipeleg33 changed the title Run quickstart tests in the CI Enhance UI tests to replace manual quickstart run when releasing OSS Jul 10, 2024
@Isan-Rivkin
Copy link
Contributor

@yonipeleg33 This looks very very clear THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants