Fix: CosmosDB EntriesIterator #8367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
bug
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
guy-har
approved these changes
Nov 14, 2024
pkg/kv/cosmosdb/store.go
Outdated
Comment on lines
462
to
464
| if e.entry != nil { | ||
| e.startKey = e.entry.Key | ||
| } |
There was a problem hiding this comment.
just a thought - but maybe we would want to log it in case this happens - just to help understand the case and how to reproduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8366
Change Description
Background
lakeFS panics due to nil pointer dereference in CosmosDB's EntriesIterator
Bug Fix
The cause of the bug is trying to access a member of a pointer without checking pointer validity
As hard as I tried, I was not able to reproduce the issue and therefore fixed the code itself but not the reason for it.
This might not be reproducible using the CosmosDB emulator.
On the bright side - I've re-enabled the CosmosDB acceptance tests in the hope that this will improve our quality
Testing Details
Ran the CosmosDB KV acceptance tests
Breaking Change?
No