Skip to content
This repository has been archived by the owner on May 23, 2020. It is now read-only.

Add onPostCreate event for activity only #62

Merged
merged 3 commits into from
Aug 5, 2016

Conversation

elsennov
Copy link
Contributor

@elsennov elsennov commented Aug 2, 2016

No description provided.

@dlew
Copy link
Contributor

dlew commented Aug 3, 2016

I'm a bit hesitant to add this since the docs say you should rarely use it. What's the use case for onPostCreate() vs. onCreate(), especially since the listener is typically fired post-super for onCreate()?

@elsennov
Copy link
Contributor Author

elsennov commented Aug 4, 2016

We need it for navigation drawer as Google suggested here
https://developer.android.com/training/implementing-navigation/nav-drawer.html

@dlew
Copy link
Contributor

dlew commented Aug 5, 2016

I looked into it and onPostCreate() is far more intriguing than I originally gave it credit. It's not called after onCreate(), it's called after onStart() and onRestoreInstanceState(). This is acceptable.

@@ -13,6 +13,7 @@
Arrays.asList(
Event.CREATE,
Event.CREATE_PERSISTABLE,
Event.POST_CREATE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: For correctness this should go after Event.START.

@elsennov
Copy link
Contributor Author

elsennov commented Aug 5, 2016

@dlew I have updated my PR based on your comments

@dlew dlew merged commit 5dc0895 into trello-archive:master Aug 5, 2016
@dlew
Copy link
Contributor

dlew commented Aug 5, 2016

Great, thanks for the work!

@dlew
Copy link
Contributor

dlew commented Aug 5, 2016

(I'll look into making another release sometime next week so you can use this stuff.)

@elsennov
Copy link
Contributor Author

elsennov commented Aug 7, 2016

Alright, you are welcome! Can't wait for the next release! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants