-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace moment with day.js #630
Comments
Instead of completely replacing, it could simply be made that, if moment doesn't exist, it would try for dayjs. It's only used in the CLI anyway. |
Is someone looking at prioritizing this? |
This package hasn't been touched in years, so I guess the best bet is to fork it and implement this change yourself. |
As there is some work happening in this repo again, i would suggest this again. I'm happy to send a pr to do this. Also another idea is to move the optional deps to peer deps, so a user can decide himself if he needs this. At renovate we recently replaced all moment refs to luxon (renovatebot/renovate#7564), but we can't get rid of moment, because of this optional dep. |
+1 let's please replace this dependency with literally anything else. Will be happy to assist if that's what's necessary |
Bump! This is the last dependency for us that requires Moment. Please consider replacing it with dayjs or another alternative. (dayjs s the most like Moment syntax-wise so might be the easiest). The creators of Moment even recommend using something else at this point. https://momentjs.com/docs/#/-project-status/ |
It's 20x lighter, https://github.com/iamkun/dayjs
The text was updated successfully, but these errors were encountered: