Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace moment with day.js #630

Open
cktang88 opened this issue Nov 28, 2019 · 7 comments
Open

Replace moment with day.js #630

cktang88 opened this issue Nov 28, 2019 · 7 comments

Comments

@cktang88
Copy link

It's 20x lighter, https://github.com/iamkun/dayjs

@cktang88
Copy link
Author

@sergejostir
Copy link

Instead of completely replacing, it could simply be made that, if moment doesn't exist, it would try for dayjs. It's only used in the CLI anyway.

@anirbansaha77
Copy link

Is someone looking at prioritizing this?

@sergejostir
Copy link

This package hasn't been touched in years, so I guess the best bet is to fork it and implement this change yourself.

@viceice
Copy link

viceice commented Oct 28, 2020

As there is some work happening in this repo again, i would suggest this again. I'm happy to send a pr to do this.

Also another idea is to move the optional deps to peer deps, so a user can decide himself if he needs this.

At renovate we recently replaced all moment refs to luxon (renovatebot/renovate#7564), but we can't get rid of moment, because of this optional dep.

@JimmayVV
Copy link

+1 let's please replace this dependency with literally anything else. Will be happy to assist if that's what's necessary

@nicoledgreene
Copy link

Bump! This is the last dependency for us that requires Moment. Please consider replacing it with dayjs or another alternative. (dayjs s the most like Moment syntax-wise so might be the easiest). The creators of Moment even recommend using something else at this point. https://momentjs.com/docs/#/-project-status/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants