Skip to content

Commit

Permalink
fix(tests): hotfix - fix update_fixtures ci --remove-missing for lang…
Browse files Browse the repository at this point in the history
… awareness

but the correct fix is to make langs a separate group
  • Loading branch information
matejcik committed Jun 6, 2024
1 parent 2bf2549 commit b868ccb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/update_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ def ci(
is_error = True
print("No results found.")
continue
_model, lang, _job = job_name.split("-")
model = next(iter(ui_res_dict.keys()))
assert model == _model
group = next(iter(ui_res_dict[model].keys()))
current_model = current_fixtures.setdefault(model, {})
current_group = current_model.setdefault(group, {}) # type: ignore
Expand All @@ -106,6 +108,8 @@ def ci(
# get rid of tests that were not run in CI
removed = 0
for key in list(current_group.keys()):
if not key.startswith(f"{model}_{lang}_"):
continue
if key not in ui_res_dict[model][group]:
current_group.pop(key)
removed += 1
Expand Down

0 comments on commit b868ccb

Please sign in to comment.