Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending arbitrary ethereum transactions (via MetaMask) doesn't show which derivation path you're working with, but should #2225

Closed
PaperHandedPuppy opened this issue Apr 21, 2022 · 1 comment
Labels
bug Something isn't working as expected

Comments

@PaperHandedPuppy
Copy link

Sending arbitrary ethereum transactions (via MetaMask) doesn't show which derivation path you're working with on your Trezor. A corrupted host computer could send the Trezor a request to sign something on a different derivation path than what your MetaMask is telling you it's signing for.

I realize that sending arbitrary transactions is a huge security risk in the first place (because good luck deciphering what you're even signing), but by simply showing the derivation path you're working with on the Trezor it would add a lot of security. For example I could restrict myself to only doing MUCH safer Eth transfers for m/44'/60'/0'/0/0 which could hold the majority of my funds, but then allow myself to send arbitrary transactions for m/44'/60'/0'/0/1 which could hold a much smaller amount.

Workaround: use passphrases, instead of derivation paths, to safely keep "accounts" separate from one another

Note: I have Trezor's "safety checks" set to "prompt" to allow myself to send arbitrary ethereum transactions via MetaMask.

@PaperHandedPuppy PaperHandedPuppy added the bug Something isn't working as expected label Apr 21, 2022
@matejcik
Copy link
Contributor

this is basically a duplicate of #2151

@matejcik matejcik moved this to 🏃‍♀️ In progress in Firmware Apr 21, 2022
@hynek-jina hynek-jina closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2022
Repository owner moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware Nov 1, 2022
@hynek-jina hynek-jina removed the status in Firmware Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Archived in project
Development

No branches or pull requests

3 participants