Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success animation for Model R #2293

Closed
sime opened this issue May 25, 2022 · 1 comment · Fixed by #2339
Closed

Success animation for Model R #2293

sime opened this issue May 25, 2022 · 1 comment · Fixed by #2339
Assignees
@mmilata @matejcik @TychoVrahe
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user T2B1 Trezor Safe 3 (F4)

Comments

@sime
Copy link
Contributor

sime commented May 25, 2022 •
edited
Loading

Design: Figma

Spec:

  • If it eases the implementation: animation can start at 12 o'clock.
  • The animation transitions at a minimum of 2x2 pixels per frame.
  • Timing is based on what feels right.

Success Sprite
@sime sime added core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user T2B1 Trezor Safe 3 (F4) labels May 25, 2022
@sime sime added this to Firmware May 25, 2022
@hynek-jina hynek-jina moved this to 🎯 To do in Firmware May 26, 2022
@sime
Copy link
Contributor Author

sime commented Jun 9, 2022

Dropping here the frames of the animation, without the centre icon.

success_animation.zip

@hynek-jina hynek-jina assigned TychoVrahe and unassigned grdddj Jun 9, 2022
@hynek-jina hynek-jina moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Jun 13, 2022
@TychoVrahe TychoVrahe mentioned this issue Jun 16, 2022
Merged
@hynek-jina hynek-jina linked a pull request Jun 21, 2022 that will close this issue
Success animation for Model R #2339
Merged
@hynek-jina hynek-jina assigned matejcik and mmilata and unassigned TychoVrahe Jun 21, 2022
@sime sime moved this from 🏃‍♀️ In progress to 🎯 To do in Firmware Jul 1, 2022
@hynek-jina hynek-jina moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Jul 18, 2022
Repository owner moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware Aug 12, 2022
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilata mmilata

@matejcik matejcik

@TychoVrahe TychoVrahe

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user T2B1 Trezor Safe 3 (F4)
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Success animation for Model R trezor/trezor-firmware
5 participants
@mmilata @sime @matejcik @TychoVrahe @grdddj