Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display only sat instead of sat BTC #2487

Closed
hynek-jina opened this issue Sep 6, 2022 · 1 comment · Fixed by #2504
Closed

Display only sat instead of sat BTC #2487

hynek-jina opened this issue Sep 6, 2022 · 1 comment · Fixed by #2504
Assignees
@marnova
Labels
bitcoin Bitcoin related low hanging fruit Simple, quick task.

Comments

@hynek-jina
Copy link

How about we leave only "sat" for Bitcoin and "sat [coin]" for all the others?

Originally posted by @tsusanka in #1369 (comment)
@hynek-jina hynek-jina added bitcoin Bitcoin related low hanging fruit Simple, quick task. labels Sep 6, 2022
@hynek-jina hynek-jina moved this to 🎯 To do in Firmware Sep 8, 2022
@marnova marnova linked a pull request Sep 9, 2022 that will close this issue
feat(core,legacy): display only sat instead of sat BTC #2504
Merged
@marnova marnova moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Sep 9, 2022
Repository owner moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware Sep 15, 2022
@STew790
Copy link

STew790 commented Sep 20, 2022

QA OK
Both T1 and TT are correctly showing only sat when sending BTC with this unit selected.

Info:

  • Suite version: web 22.9.2 (cfeba9a3533ec7f4a5d4f31da4ac8c8b768547ed)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.5.3 Universal (revision 4bed278)
  • Device: model 1 1.11.3 Universal (revision 4bed278)
  • Transport: bridge 2.0.32

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Firmware Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marnova marnova

Labels
bitcoin Bitcoin related low hanging fruit Simple, quick task.
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core,legacy): display only sat instead of sat BTC trezor/trezor-firmware
3 participants
@hynek-jina @STew790 @marnova