Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI2: send transaction style update #2680

Closed
mmilata opened this issue Dec 13, 2022 · 9 comments · Fixed by #2925
Closed

UI2: send transaction style update #2680

mmilata opened this issue Dec 13, 2022 · 9 comments · Fixed by #2925
Assignees
Labels
code Code improvements

Comments

@mmilata
Copy link
Member

mmilata commented Dec 13, 2022

image

fixes #2151

@mmilata mmilata added the code Code improvements label Dec 13, 2022
@mmilata mmilata self-assigned this Dec 13, 2022
@Hannsek
Copy link
Contributor

Hannsek commented Dec 13, 2022

@hynek-jina hynek-jina moved this to 🎯 To do in Firmware Jan 19, 2023
@Hannsek Hannsek added the blocked Blocked by external force. Third party inputs required. label Jan 20, 2023
@Hannsek
Copy link
Contributor

Hannsek commented Jan 20, 2023

New design is coming. For now, this is blocked.

@mmilata
Copy link
Member Author

mmilata commented Feb 6, 2023

Is this still blocked or is the figma design ready now?

@Hannsek
Copy link
Contributor

Hannsek commented Feb 6, 2023

Still not ready, I hope it will be ready next week…

@Hannsek
Copy link
Contributor

Hannsek commented Feb 9, 2023

image

image

Figma file: https://www.figma.com/file/l0gG9XeRJ8FTDQ3cfb1wv9/Trezor-T%2C-Trezor-One?node-id=6276%3A46984&t=fVkX6Rym50TQFKbi-4

Design is ready @mmilata. For now we won't use the chunks when displaying address. Later on we will use it.

@Hannsek Hannsek removed the blocked Blocked by external force. Third party inputs required. label Feb 9, 2023
@andrewkozlik
Copy link
Contributor

In the recipient #1 screen:

  • I think showing the currency in the account label is open for discussion. It should be the same as the currency that we are spending. If it's not, e.g. we are sending LTC to a BTC path, then it seems more appropriate to show the path, than trying to assign a name to it.
  • I think we really need to use the word "account" in the account label. L. SegWit #223 just seems unclear what it means, i.e. L. SegWit account #223.

@Hannsek
Copy link
Contributor

Hannsek commented Feb 16, 2023

I agree with both of your points.
image

sending LTC to a BTC path is allowed only behind safety checks, right?

@andrewkozlik
Copy link
Contributor

sending LTC to a BTC path is allowed only behind safety checks, right?

Probably yes, but I think there might be some coin combinations which allow it even without safety checks. Those that have fork ID defined may allow it (Bitcoin Cash, Bitcoin Gold, Bitcoin Private). But my point is that it doesn't seem to make sense to assign a name to the account in that case, because the user will not see the incoming transaction in their Bitcoin account. If there is a coin name in the account label, then it should represent the network, not the path. (I think in the T1 implementation it actually represents the path, which is why I am saying it's open for discussion, because I don't really understand the rationale for that.)

@Hannsek
Copy link
Contributor

Hannsek commented Feb 27, 2023

Image

We cannot fit the word account in the account label as we have switched to bigger font. So for now, let's do this without it.

@Hannsek Hannsek removed this from the 🖼️ UI2 release milestone Mar 23, 2023
@mmilata mmilata moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Mar 30, 2023
@Hannsek Hannsek removed their assignment Mar 30, 2023
@Hannsek Hannsek linked a pull request Apr 4, 2023 that will close this issue
@Hannsek Hannsek closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants