-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI2: send transaction style update #2680
Comments
New design is coming. For now, this is blocked. |
Is this still blocked or is the figma design ready now? |
Still not ready, I hope it will be ready next week… |
Design is ready @mmilata. For now we won't use the chunks when displaying address. Later on we will use it. |
In the
|
Probably yes, but I think there might be some coin combinations which allow it even without safety checks. Those that have fork ID defined may allow it (Bitcoin Cash, Bitcoin Gold, Bitcoin Private). But my point is that it doesn't seem to make sense to assign a name to the account in that case, because the user will not see the incoming transaction in their Bitcoin account. If there is a coin name in the account label, then it should represent the network, not the path. (I think in the T1 implementation it actually represents the path, which is why I am saying it's open for discussion, because I don't really understand the rationale for that.) |
fixes #2151
The text was updated successfully, but these errors were encountered: