You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mmilata opened this issue
Jun 6, 2024
· 3 comments
· Fixed by #4375
Assignees
Labels
bugSomething isn't working as expectedcodeCode improvementscoreTrezor Core firmware. Runs on Trezor Model T and T2B1.T3T1Trezor Safe 5testsAutomated integration tests
Get stuck on the first tap-to-confirm screen. Reproducible on emulator by leaving animations enabled.
The text was updated successfully, but these errors were encountered:
mmilata
added
core
Trezor Core firmware. Runs on Trezor Model T and T2B1.
bug
Something isn't working as expected
tests
Automated integration tests
code
Code improvements
T3T1
Trezor Safe 5
labels
Jun 6, 2024
the issue (or at least one of the issues) is that the layout does not change when swipe occurs, but later after some animation frames.
Thus, the notify_layout_change function is called too early and the test does not see the new layout.
Proper solution is probably introduce some notify layout change to EventCtx, call it whenever the layout really changes in rust and handle this flag from python by calling that notify_layout_change function
i'll see if GFL #3686 can help here too -- at least the framework is solid enough for it, but the fact that the flows now happen in Rust brings some challenges
#4375 resolves the issue at hand by disabling animations on HW debug builds.
tests are still broken with animations on, but it doesn't seem worth the effort to fix it cleanly, given that the work is only useful for tests, where we don't run the animations.
bugSomething isn't working as expectedcodeCode improvementscoreTrezor Core firmware. Runs on Trezor Model T and T2B1.T3T1Trezor Safe 5testsAutomated integration tests
Get stuck on the first tap-to-confirm screen. Reproducible on emulator by leaving animations enabled.
The text was updated successfully, but these errors were encountered: