Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device tests don't work against T3T1 hardware #3915

Closed
mmilata opened this issue Jun 6, 2024 · 3 comments · Fixed by #4375
Closed

Device tests don't work against T3T1 hardware #3915

mmilata opened this issue Jun 6, 2024 · 3 comments · Fixed by #4375
Assignees
Labels
bug Something isn't working as expected code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. T3T1 Trezor Safe 5 tests Automated integration tests

Comments

@mmilata
Copy link
Member

mmilata commented Jun 6, 2024

Get stuck on the first tap-to-confirm screen. Reproducible on emulator by leaving animations enabled.

@mmilata mmilata added core Trezor Core firmware. Runs on Trezor Model T and T2B1. bug Something isn't working as expected tests Automated integration tests code Code improvements T3T1 Trezor Safe 5 labels Jun 6, 2024
@TychoVrahe
Copy link
Contributor

the issue (or at least one of the issues) is that the layout does not change when swipe occurs, but later after some animation frames.

Thus, the notify_layout_change function is called too early and the test does not see the new layout.

Proper solution is probably introduce some notify layout change to EventCtx, call it whenever the layout really changes in rust and handle this flag from python by calling that notify_layout_change function

@matejcik
Copy link
Contributor

matejcik commented Jun 6, 2024

i'll see if GFL #3686 can help here too -- at least the framework is solid enough for it, but the fact that the flows now happen in Rust brings some challenges

@matejcik
Copy link
Contributor

#4375 resolves the issue at hand by disabling animations on HW debug builds.
tests are still broken with animations on, but it doesn't seem worth the effort to fix it cleanly, given that the work is only useful for tests, where we don't run the animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. T3T1 Trezor Safe 5 tests Automated integration tests
Projects
Status: 🎯 To do
Development

Successfully merging a pull request may close this issue.

3 participants