Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock from Device 🔒 #1404

Closed
tsusanka opened this issue Jan 4, 2021 · 2 comments · Fixed by #1422
Closed

Lock from Device 🔒 #1404

tsusanka opened this issue Jan 4, 2021 · 2 comments · Fixed by #1422
Assignees
@mmilata
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone
21.03

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Jan 4, 2021 •
edited
Loading

Before #61 is tackled we would like to add at least the option to lock the device. The idea is that if you hold your finger on the homepage screen you will be prompted whether you indeed want to lock the device. Eventually in #61 the hold will be replaced with some menu where the lock is one of the options.

It is the same thing as T1 has when you hold left button for 5s. Let's use the same delay.
@tsusanka tsusanka added core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature labels Jan 4, 2021
@tsusanka tsusanka added this to the 2021-02 milestone Jan 4, 2021
@mmilata mmilata mentioned this issue Jan 19, 2021
Merged
@tsusanka tsusanka modified the milestones: 21.02, 21.03 Jan 22, 2021
@tsusanka tsusanka changed the title Add option to lock the device from the screen on TT Lock from Device 🔒 Jan 26, 2021
@tsusanka tsusanka changed the title Lock from Device 🔒 Lock from Device 🔒 Jan 26, 2021
@jziggas jziggas mentioned this issue Apr 19, 2021
Closed
@STew790 STew790 reopened this Jun 2, 2021
@STew790 STew790 closed this as completed Jun 2, 2021
@STew790
Copy link

STew790 commented Jun 2, 2021

QA OK

Holding a finger on screen locks the device.

Info:

  • Suite version: web 21.6.1 (7d50da6b9fe39ddd934fdf6153b4c4afb2d7fd88)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.4.0 071c6c0

@wendys-cats
Copy link

QA OK

PIN needs to be enabled.
Pressing a finger on screen tiggers locking for TT.
Holding the left button triggers locking for T1.

Info:

  • Suite version: web 21.6.1 (7d50da6b9fe39ddd934fdf6153b4c4afb2d7fd88)
  • Browser: Chromium Version 88.0.4324.182 (Official Build) (64-bit)
  • OS: NixOS 21.03
  • Device: TT 2.4.0 071c6c0 and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilata mmilata

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Milestone
21.03
Development

Successfully merging a pull request may close this issue.

Lock TT by holding finger on home screen trezor/trezor-firmware
5 participants
@mmilata @tsusanka @matejzak @STew790 @wendys-cats