-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Firo support. Solved scriptSig size limits #1767
Comments
Is there a running testnet where we could verify that this works? |
hmm, this still means that existing shielded txes will be unspendable because they are already encoded with the original method, correct? |
Existing funds that have already been sent into the Trezor using Lelantusjsplit transactions as input would be unspendable and would need to be recovered using the seed. Don't think there can be any workaround for this but I believe this should be a minority of users from the support requests we have received compared to those locked out from losing firmware support. However, any new funds coming from Lelantusjsplit should now work once the hard fork date rolls around. Our existing testnet is already setup to test this. Please view the transaction on testnet here. |
|
Here are the two Lelantusjsplit (new format) to addresses generated from https://testblockbook.firo.org/tx/8a34ccceaf138fd14398303340afb37871cb0ea6719ceba315172edb9ff6d625 https://testblockbook.firo.org/tx/fdb1a55c8aaa9b3f56efa0852090272a8717544ec9303876fcc097a5ec9c6c6a |
@justanwar what derivation paths are these? I can't find them in the usual places (that is |
@matejcik The derivation paths for the addresses:
|
thanks for your cooperation folks |
Firo (formerly Zcoin) support was dropped because Lelantus spends to the Trezor made it unspendable. This was due to Lelantus using scriptSig and exceeding the size limits. See issue #1588
We have rectified this issue and implemented the recommended fix which is to move this data out
firoorg/firo#1063
firoorg/firo@2cfa8e9
This requires a hard fork which will be completed by block 401580 (approximately August 26 2021).
https://github.com/firoorg/firo/releases/tag/v0.14.8.0
The only thing that needs to be done on Trezor's side is to ensure the firmware has support for extra payload for Firo which I believe is already enabled. As long as it's enabled, nothing else needs to be done.
Would greatly appreciate Firo to be re-enabled as many of our users rely on Trezor to store their Firo.
@matejcik
The text was updated successfully, but these errors were encountered: