fix(xmr): Remove inv8 optimization as in xmr master #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will you please provide the sha256 of the binary? |
@prusnak I've added it to the release notes this time :) |
ph4r05
force-pushed
the
pr/006-xmr-bpp-revinv8
branch
from
4849254
to
efee0df
Compare
|
I've changed testing binary info in the PR (forgot to do that originally) |
matejcik
approved these changes
Jun 7, 2022
|
waiting for CI run before merging |
|
yup \o/ |
|
I will have to make one more PR regarding view tags: monero-project/monero@ea87b30 Some time this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was notified that Monero changed a BP+ result format in this PR: monero-project/monero#8277
As it affects XMR transaction signing, we have to adapt to the change. Corresponding changes in the Trezor-client code in the XMR wallet are already incorporated in the monero-project/monero#8299
I will send a testing binary once I manage to build it (should be soon).
PR is related to the: