Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stack to the start of the address space #2427

Closed
matejcik opened this issue Aug 1, 2022 · 0 comments · Fixed by #2444
Closed

Move stack to the start of the address space #2427

matejcik opened this issue Aug 1, 2022 · 0 comments · Fixed by #2444
Assignees
@hiviah @TychoVrahe
Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4)

Comments

@matejcik
Copy link
Contributor

matejcik commented Aug 1, 2022

To avoid memory corruption when our stack overflows into the GC arena -- or anywhere, for that matter -- we can move the stack to the start of the address space. Then when something overflows the stack, we will see a crash immediately, and will have a much easier time tracing what code caused it.
@matejcik matejcik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. code Code improvements labels Aug 1, 2022
@hynek-jina hynek-jina added the T2B1 Trezor Safe 3 (F4) label Aug 4, 2022
@hynek-jina hynek-jina moved this to 🎯 To do in Firmware Aug 4, 2022
@hynek-jina hynek-jina mentioned this issue Aug 4, 2022
Closed
@TychoVrahe TychoVrahe moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Aug 9, 2022
@TychoVrahe TychoVrahe linked a pull request Aug 10, 2022 that will close this issue
Introduce stack overflow detection by moving stack to the start of RAM #2444
Merged
Repository owner moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware Aug 16, 2022
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware Sep 25, 2022
@matejcik matejcik mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiviah hiviah

@TychoVrahe TychoVrahe

Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4)
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce stack overflow detection by moving stack to the start of RAM trezor/trezor-firmware
4 participants
@matejcik @hiviah @hynek-jina @TychoVrahe