Monero primary address discrepancy between app and device

[bosomt]

Describe the bug
I'm not sure if its expected or not or if it's problem with moneroGUI or Trezor.
But i was not able to replicate it with 2.5.1 FW.
When i press show address on device i see completely different address.
But it belongs to same account /i just sent some Monero to that address and i still have same amount of xmr.

When you create secondary address it works as expected. Device and app address does match, looks like only Primary address is affected.

Firmware version and revision

QA NOK Device: model T 2.5.2 regular (revision 0d87b55)
QA OK Device: model T 2.5.1 regular (revision 85a26d2)

Desktop/smartphone setup (please complete the following information):

• Wallet software: moneroGUI 0.18.1.0-release (Qt 5.12.8)
• OS: macARM

To Reproduce
Steps to reproduce the behavior:

1. Go to moneroGUI/Receive
2. Click on Shonw on device
3. Check address on device display and confirm
4. Compare with address displayed in app

Screenshots

[matejcik]

@ph4r05 please take a look.
i vaguely remember something about unified addresses, could this be it?

[ph4r05]

Interesting! Thanks for the report. Unfortunately, I am quite busy till 11.9.2022 so I am not sure I will find time to take a look at this till then.

[matejcik]

@selsta since you are involved here, anything you can tell us about this issue from a quick look?
something something integrated address?

[selsta]

This does not seem related to integrated addresses. The primary address is a special case, it seems the firmware simply calculated subaddress(0, 0) instead of displaying the primary address. Should be easy to fix.

[ph4r05]

Thanks for the diagnosis, @selsta. Your hypothesis seems to be correct. If subaddress indices are (0, 0), primary address should be displayed.

@matejcik this code is causing it

trezor-firmware/core/src/apps/monero/get_address.py

Lines 48 to 60 in 33c1744

	if have_subaddress:
	assert msg.account is not None
	assert msg.minor is not None
	pub_spend, pub_view = monero.generate_sub_address_keys(
	creds.view_key_private, creds.spend_key_public, msg.account, msg.minor
	)
	addr = addresses.encode_addr(
	net_version(msg.network_type, True, False),
	crypto_helpers.encodepoint(pub_spend),
	crypto_helpers.encodepoint(pub_view),
	)

PR #2478 fixes it (not tested).

[bosomt]

@ph4r05 looks like we need new moneroGUI version to test this fix, im not able to open or create new wallet.

monero-gui-mac-x64-v0.18.1.1

2022-09-20 18:45:21.983	E Get public address exception: Call method failed
2022-09-20 18:45:21.985	E Cannot get a device address

[selsta]

This should be a purely firmware side issue, I don't see why a new GUI version should be required here. Did you make sure the Trezor bridge is installed?

[bosomt]

Yes I have but new version Version: 2.0.32, as soon i changed it to Version: 2.0.31 and disabled PIN code im able to connect to device.

[bosomt]

QA OK

addresses works as expected

• Device: model T 2.5.3 Universal (revision 4bed278)
• Transport: bridge 2.0.31

[selsta]

might make sense to look into why bridge version 2.0.32 fails, but that's for a different issue

[bosomt]

Works as expected today with 2.0.32 🤷🏿‍♂️