core: rudimentary BLE support #3501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no changelog] Co-authored-by: Martin Milata <martin@martinmilata.cz>
[no changelog] Co-authored-by: Martin Milata <martin@martinmilata.cz>
[no changelog] Co-authored-by: Martin Milata <martin@martinmilata.cz>
mmilata
commented
Jan 25, 2024
| MessageType_BLERepairRequest = 8005 [(bitcoin_only) = true, (wire_in) = true]; | ||
| MessageType_BLEEraseBonds = 8006 [(bitcoin_only) = true, (wire_in) = true]; | ||
| MessageType_BLEDisconnect = 8007 [(bitcoin_only) = true, (wire_in) = true]; | ||
| MessageType_BLEComparisonRequest = 8008 [(bitcoin_only) = true, (wire_in) = true]; |
There was a problem hiding this comment.
The internal messages probably deserve their own wire_... flag.
|
is this maybe deprecated and should be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @TychoVrahe's
tychovrahe/T3W1/devkit1_with_ble_crypto3but keeps only subset of hardware-independent changes. For working devkit firmware I've rebased everything on top of this branch atmmilata/ble-rebased. Notably left out from this PR:Fixes #2725. Related: #3083, #2299, #79.