Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account under "i" in receive flow is always 'ETH #1', regardless of derivation path #3627

Closed
Hannsek opened this issue Mar 20, 2024 · 4 comments · Fixed by #4117
Closed

Account under "i" in receive flow is always 'ETH #1', regardless of derivation path #3627

Hannsek opened this issue Mar 20, 2024 · 4 comments · Fixed by #4117
Assignees
Labels
altcoin Any non-Bitcoin coins bug Something isn't working as expected

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Mar 20, 2024

Describe the bug
Account is always 'ETH #1', regardless of derivation path

Firmware version and revision
2.7.0

image image
@Hannsek Hannsek added altcoin Any non-Bitcoin coins bug Something isn't working as expected labels Mar 20, 2024
@Hannsek Hannsek added this to Firmware Mar 20, 2024
@Hannsek Hannsek moved this to 🎯 To do in Firmware Aug 2, 2024
@ibz
Copy link
Contributor

ibz commented Aug 16, 2024

The address format is m/44'/coin_type'/account'/change/address_index, so in both screenshots above the account is /0 which is #1.

If I replace the \0 with \2, I get ETH #3, for example...

image

@prusnak
Copy link
Member

prusnak commented Aug 16, 2024

The address format is m/44'/coin_type'/account'/change/address_index, so in both screenshots above the account is /0 which is #1.

Please sync with Suite on this. I think they (mis-)use address index as accounts (like other ETH wallets do).

@Hannsek
Copy link
Contributor Author

Hannsek commented Aug 17, 2024

In Trezor Suite, we use this derivation path for Ethereum when creating new accounts (addresses):m/44'/60'/0'/0/{account_index}

So it is like @prusnak says.

We also support discovering Ledger paths:
Ledger (live): m/44'/60'/{account_index}'/0/0
Ledger (legacy): m/44'/60'/0'/{account_index}

@bosomt
Copy link

bosomt commented Oct 11, 2024

QA OK

Info:

  • Suite version: web 24.11.0 (65a8499db01e2226de44c748e725e0bf976b3ee5)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.4 regular (revision d71d9e9)
  • Device: Trezor T2T1 2.8.4 regular (revision d71d9e9)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🎯 To do to ✅ Approved in Firmware Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoin Any non-Bitcoin coins bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants