Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: actions: translations label trigger, update_fixtures.py support #3639

Merged
merged 5 commits into from
Mar 25, 2024
Merged

ci: actions: translations label trigger, update_fixtures.py support #3639

merged 5 commits into from
Mar 25, 2024

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 22, 2024 •
edited
Loading

  • all-language test suite was previously run only once after adding the translations label, now it runs every time the label is present
  • tests/update-fixtures.py ci --github now fetches fixtures.results.json from GitHub Actions (GitLab has no T3T1), followup of github actions: test translations #3549

@mmilata mmilata added the translations Put this label on a PR to run tests in all languages label Mar 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@github-actions GitHub Actions
Copy link

legacy UI changes device test(screens) main(screens)

@mmilata mmilata changed the title ci: actions: fix translations label trigger ci: actions: translations label trigger, update_fixtures.py support Mar 22, 2024
@mmilata mmilata self-assigned this Mar 22, 2024
@mmilata mmilata marked this pull request as ready for review March 22, 2024 17:27
@mmilata mmilata requested a review from matejcik as a code owner March 22, 2024 17:27
@mmilata mmilata requested a review from grdddj March 22, 2024 17:37
matejcik
matejcik approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, seems nice

grdddj
grdddj approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@grdddj grdddj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

And thanks for fixing the ##START_DEVICE_TESTS lint

@mmilata mmilata merged commit 866853e into main Mar 25, 2024
102 of 103 checks passed
@mmilata mmilata deleted the mmilata/ci branch March 25, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdddj grdddj grdddj approved these changes

@matejcik matejcik matejcik approved these changes

Assignees

@mmilata mmilata

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmilata @matejcik @grdddj