Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enter passphrase on device flow - small tweaks #4054

Closed
Tracked by #3748
Hannsek opened this issue Jul 23, 2024 · 1 comment · Fixed by #4094
Closed
Tracked by #3748

Enter passphrase on device flow - small tweaks #4054

Hannsek opened this issue Jul 23, 2024 · 1 comment · Fixed by #4094
Assignees
@obrusvit
Labels
T3T1 Trezor Safe 5
Milestone
T3T1

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Jul 23, 2024

Design: Figma

Adding the button and adding reassuring screen when entering empty passphrase.
@Hannsek Hannsek added the T3T1 Trezor Safe 5 label Jul 23, 2024
@Hannsek Hannsek added this to the T3T1 milestone Jul 23, 2024
@Hannsek Hannsek added this to Firmware Jul 23, 2024
@Hannsek Hannsek moved this to 🎯 To do in Firmware Jul 23, 2024
@obrusvit obrusvit self-assigned this Jul 31, 2024
@obrusvit obrusvit mentioned this issue Aug 1, 2024
Open
1 task
@obrusvit obrusvit linked a pull request Aug 7, 2024 that will close this issue
T3T1 UI - passphrase flow improvement #4094
Merged
@obrusvit obrusvit moved this from 🎯 To do to 🔎 Needs review in Firmware Aug 12, 2024
@obrusvit obrusvit moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 22, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware Aug 27, 2024
@bosomt
Copy link

bosomt commented Aug 27, 2024

QA OK

Info:

  • Suite version: web 24.9.0 (492ff5f8f3bb0fddae885f29d678e171305623a0)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.2 regular (revision c8b811b)
  • Transport: BridgeTransport 2.0.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obrusvit obrusvit

Labels
T3T1 Trezor Safe 5
Projects
Firmware
Archived in project
Milestone
T3T1
Development

Successfully merging a pull request may close this issue.

T3T1 UI - passphrase flow improvement trezor/trezor-firmware
3 participants
@obrusvit @bosomt @Hannsek