Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't shut down emulator while waiting for a ButtonAck #973

Closed
matejcik opened this issue Apr 30, 2020 · 2 comments · Fixed by #2257
Closed

Can't shut down emulator while waiting for a ButtonAck #973

matejcik opened this issue Apr 30, 2020 · 2 comments · Fixed by #2257
Assignees
@matejcik
Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. emulator only Issue which does not appear on the physical device - but on emulator only.

Comments

@matejcik
Copy link
Contributor

While stuck waiting on ctx.call(), emulator does not respond to SIGINT or SIGTERM and must be SIGKILLed to shut it down.
@matejcik matejcik added the bug Something isn't working as expected label Apr 30, 2020
@matejcik matejcik self-assigned this Apr 30, 2020
@matejcik matejcik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. emulator only Issue which does not appear on the physical device - but on emulator only. code Code improvements P4 Low labels Apr 30, 2020
@prusnak prusnak added this to the backlog milestone Jun 7, 2020
@tsusanka tsusanka removed W2 labels Feb 19, 2021
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@tsusanka tsusanka removed the bug Something isn't working as expected label Oct 7, 2021
@matejcik matejcik mentioned this issue Feb 18, 2022
Draft
matejcik added a commit that referenced this issue May 5, 2022
@matejcik
fix(core/emulator): make sure SDL keyboard and quit events are always…
7ac3958 
… processed

fixes #973
@hynek-jina hynek-jina removed the LOW label May 6, 2022
matejcik added a commit that referenced this issue May 6, 2022
@matejcik
fix(core/emulator): make sure SDL keyboard and quit events are always…
33d553c 
… processed

fixes #973
@matejcik matejcik mentioned this issue May 6, 2022
Merged
matejcik added a commit that referenced this issue May 16, 2022
@matejcik
fix(core/emulator): make sure SDL keyboard and quit events are always…
99c817b 
… processed

fixes #973
@matejcik matejcik moved this to 🤝 Needs QA in Firmware May 16, 2022
@bosomt
Copy link

bosomt commented May 16, 2022

@matejcik just emulator stuff, no need to test it on our side, right ?

@matejcik
Copy link
Contributor Author

correct!

@matejcik matejcik moved this from 🤝 Needs QA to ✅ Approved in Firmware May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1. emulator only Issue which does not appear on the physical device - but on emulator only.
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure emulator can be shut down while waiting trezor/trezor-firmware
5 participants
@prusnak @matejcik @tsusanka @hynek-jina @bosomt