Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decreasing the output value in RBF transactions #3460

Closed
tsusanka opened this issue Feb 22, 2021 · 4 comments
Closed

Allow decreasing the output value in RBF transactions #3460

tsusanka opened this issue Feb 22, 2021 · 4 comments
Assignees
@szymonlesisz
Labels
transactions Transaction history page

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Feb 22, 2021 •
edited by matejzak
Loading

After trezor/trezor-firmware#1491 is done it will be possible to decrease ouput value during the RBF process which is very useful for sweeping accounts (sending maximum from your account).

Multiple outputs TX scenario, where user is asked to select the particular output to be decreased: Design (4th screen)
@tsusanka tsusanka added feature Product related issue visible for end user transactions Transaction history page labels Feb 22, 2021
@matejzak matejzak assigned matejzak and unassigned alex-jerechinsky Mar 4, 2021
@prusnak prusnak mentioned this issue Apr 16, 2021
Closed
@szymonlesisz szymonlesisz self-assigned this May 11, 2021
@matejzak matejzak removed their assignment May 11, 2021
@matejzak matejzak removed the feature Product related issue visible for end user label May 11, 2021
@matejzak
Copy link

Just discussed with @szymonlesisz:

  • Let's use already existing context warning message saying the amount has been decreased + the new amount.

(Example)
Screen Shot 2021-05-11 at 13 39 40

  • Let's add the confirmation items (as per FW request) to the transaction confirmation modal.

@szymonlesisz
Copy link
Contributor

this is already merged by #3827

@bosomt
Copy link
Contributor

bosomt commented Jun 24, 2021

QA OK

#3827 (comment)

@STew790
Copy link
Contributor

STew790 commented Jul 2, 2021

QA OK

Info:

  • Suite version: desktop 21.7.0 (550942d)
  • Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.7.0 Chrome/89.0.4389.69 Electron/12.0.0 Safari/537.36
  • OS: Win32
  • Screen: 1920x1080
  • Device: model T 2.4.0 regular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonlesisz szymonlesisz

Labels
transactions Transaction history page
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tsusanka @szymonlesisz @matejzak @bosomt @STew790 @alex-jerechinsky