Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Error includes first line of backtrace #256

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Build Error includes first line of backtrace #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
master
------

* `BuildError#message` includes first line of backtrace. [#256]
* Exposes `build_timeout` configuration as `ENV["EMBER_BUILD_TIMEOUT"]`.
* Change default `build_timeout` to `15` seconds.
* Symlink `dist/` directly to Asset Pipeline [#250]
* Merge EmberCLI-generated `manifest.json` into Sprocket's [#250]
* `manifest.json`. Since we now defer to EmberCLI, we no longer need to
manually resolve asset URLs. [#250]

[#256]: https://github.com/thoughtbot/ember-cli-rails/pull/256
[#250]: https://github.com/thoughtbot/ember-cli-rails/pull/250

0.4.3
Expand Down
8 changes: 6 additions & 2 deletions lib/ember-cli/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@ def build_error?
end

def raise_build_error!
error = BuildError.new("EmberCLI app #{name.inspect} has failed to build")
error.set_backtrace build_error_file_path.readlines
backtrace = build_error_file_path.readlines.reject(&:blank?)
message = "#{name.inspect} has failed to build: #{backtrace.first}"

error = BuildError.new(message)
error.set_backtrace(backtrace)

fail error
end

Expand Down