Binary serialization over pipes

[xy2i]

We use UnixStream::pair() a few times and reimplement binary ser/de each time. Add an abstraction that does the serde (BinSerDe) and buffer ceremony (BinPipe) for us.

Fixes #471.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@6d40763). Click here to learn what that means.
Patch coverage: 51.63% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage        ?   55.28%           
=======================================
  Files           ?       72           
  Lines           ?     9835           
  Branches        ?        0           
=======================================
  Hits            ?     5437           
  Misses          ?     4398           
  Partials        ?        0           

Files Changed	Coverage Δ
src/exec/no_pty.rs	0.00% <0.00%> (ø)
src/exec/use_pty/backchannel.rs	0.00% <0.00%> (ø)
src/exec/use_pty/monitor.rs	0.00% <0.00%> (ø)
src/common/bin_serde.rs	91.30% <91.30%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xy2i]

Thank you for your review !

I ran into an issue I feel like is blocking, which I couldn't work around (see the review above). If there's no good work around I'm okay closing this PR, but let me know.

[pvdrz]

@xy2i oh silly me... Yeah I forgot that const generics is very minimal right now. But this is no reason to not merge your PR. There might be an alternative but I'm not sure how well it works:

mod sealed {
    pub trait DeSerializeBytes {}
    
    impl<const N: usize> DeSerializeBytes for [u8; N] {}
}

pub trait DeSerialize {
    type Bytes: sealed::DeSerializeBytes;
    fn serialize(&self) -> Self::Bytes;
    fn deserialize(bytes: Self::Bytes) -> Self;
}

impl DeSerialize for i32 {
    type Bytes = [u8; std::mem::size_of::<Self>()];
    
    fn serialize(&self) -> Self::Bytes {
        self.to_ne_bytes()    
    }
    
    fn deserialize(bytes: Self::Bytes) -> Self {
        Self::from_ne_bytes(bytes)
    }
}

Let me know if you think that's good enough. Otherwise, we can merge this as it is I think :)

Thanks!

[xy2i]

That works, thanks !

[pvdrz]

Thanks for this!