Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex Sorting Only works first time or only works in one direction (in Admin) #92

Closed
PalmTreeVI opened this issue Dec 21, 2020 · 3 comments
Assignees
Labels
bug Something isn't working fixed Issue has already been fixed

Comments

@PalmTreeVI
Copy link

PalmTreeVI commented Dec 21, 2020

When I click a header item for example Name it sorts data table in ascending order correctly

But when I click Name again, the ordering does not reverse table into descending order.

The direction icons to right of header item clicked does update accordingly with up or down arrows.

Grav v1.7.0-rc.20 - Admin v1.10.0-rc.2

Here is example screen before clicking a header

Screenshot_2020-12-20_14-08-55

Here is after the first click of Score header

Screenshot_2020-12-20_14-05-54

And finally, a second click of the Score header

Screenshot_2020-12-20_14-06-19

Notice the header direction arrows update accordingly but that the data does not change.

@PalmTreeVI PalmTreeVI changed the title Flex Sorting 1Only works first time or only works in one direction (in Admin) Flex Sorting Only works first time or only works in one direction (in Admin) Dec 21, 2020
@w00fz
Copy link
Member

w00fz commented Dec 21, 2020

Thanks for opening this @PalmTreeVI

@w00fz w00fz added the bug Something isn't working label Dec 21, 2020
@w00fz
Copy link
Member

w00fz commented Dec 21, 2020

I can confirm the issue Matias.

To replicate, go in /admin/accounts/users, sort by username twice and you’ll notice nothing changes. However, I am sending the property sort: username|asc and sort: username|desc accordingly but it’s always returned asc.

@mahagr mahagr added the fixed Issue has already been fixed label Dec 23, 2020
@mahagr
Copy link
Contributor

mahagr commented Dec 23, 2020

Fixed in getgrav/grav@bc2435e

@mahagr mahagr closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has already been fixed
Projects
None yet
Development

No branches or pull requests

3 participants