-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] turn app into navigator #304
Draft
spalmer25
wants to merge
11
commits into
palmer@functori@sort-and-merge-nano-tests
Choose a base branch
from
palmer@functori@test-turn-app-into-navigator
base: palmer@functori@sort-and-merge-nano-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[test] turn app into navigator #304
spalmer25
wants to merge
11
commits into
palmer@functori@sort-and-merge-nano-tests
from
palmer@functori@test-turn-app-into-navigator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
changed the base branch from
main
to
palmer@functori@sort-and-merge-nano-tests
November 29, 2024 09:12
spalmer25
force-pushed
the
palmer@functori@sort-and-merge-nano-tests
branch
from
November 29, 2024 13:01
8b81fc8
to
474d918
Compare
encode signature as pytezos do
This allow easy public key check
This allow a better error handling for send-and-navigate
spalmer25
force-pushed
the
palmer@functori@test-turn-app-into-navigator
branch
from
November 29, 2024 14:14
d28f0b4
to
2982d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #303
In test, the
TezosAppScreen
class has become a class for batching every function needed for tests.This situation has moved the aim of the tests inside this class, and it has become more difficult to add tests or modify them.
This PR change the responsibility of the
TezosAppScreen
to aragger
navigator for the Tezos app.The
TezosAppScreen
class will be the main code changed when theTouch
device tests will be included.