Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-sort attribute for column sorting #1977

Closed
2 tasks done
coliff opened this issue Dec 21, 2023 · 0 comments · Fixed by #2425
Closed
2 tasks done

Add aria-sort attribute for column sorting #1977

coliff opened this issue Dec 21, 2023 · 0 comments · Fixed by #2425
Assignees
@ElishaSamPeterPrabhu
Labels
1 1 story point accessibility bug Something is wrong and needs to be addressed good-first-issue A good issue for developers who have yet to contribute to the repo

Comments

@coliff
Copy link
Member

coliff commented Dec 21, 2023

Prerequisites

Describe the issue

It'd be good to add aria-sort attribute to table headers when using column sort.

Some details here:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-sort

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

Low

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

No

Are you using Modus Web Components in production ?

No response
@coliff coliff added the bug Something is wrong and needs to be addressed label Dec 21, 2023
@rthanga1 rthanga1 added 1 1 story point good-first-issue A good issue for developers who have yet to contribute to the repo labels Jan 11, 2024
@coliff coliff mentioned this issue Feb 16, 2024
Open
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu mentioned this issue Apr 9, 2024
Merged
13 tasks
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
1 1 story point accessibility bug Something is wrong and needs to be addressed good-first-issue A good issue for developers who have yet to contribute to the repo
Projects
Modus Web Components
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Table: Add aria-sort to header trimble-oss/modus-web-components
3 participants
@coliff @rthanga1 @ElishaSamPeterPrabhu