Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: Make profile optional #2128

Closed
2 tasks done
cjwinsor opened this issue Feb 7, 2024 · 1 comment
Closed
2 tasks done

Navbar: Make profile optional #2128

cjwinsor opened this issue Feb 7, 2024 · 1 comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@cjwinsor
Copy link
Contributor

cjwinsor commented Feb 7, 2024

Prerequisites

Proposal

Add a show-profile property to the Navbar, defaulting to true. We've decided to default to true to avoid introducing a breaking change, while also maintaining consistency with the existing show- prefix nomenclature in our properties.

Motivation and context

There are scenarios where providing the user the option to sign out is unfavorable. In the known instances, the profile menu is not necessary. The provided scenarios were:

  1. Tekla Assistant window that is opening a website inside a desktop application, providing user details or sign out options does not make sense in this context
  2. e-Builder popup windows - Signing out from a popup window does not make sense based on desired user flow. The user should not be able to navigate to another page via profile menu links that take them back to the full page experience inside a popup window. User delegation feature allows for switching of user context which could create confusion as the main page wouldn't update to reflect immediately.

Although this leads to the ability to use the buttons prop to define your own avatar button, this is not a supported use case by the modus design system. To comply with guidelines, if a profile and profile menu are needed then the built in profile should be used.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@cjwinsor cjwinsor changed the title Navbar: Make avatar optional Navbar: Make profile optional Feb 7, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Feb 7, 2024
@cjwinsor
Copy link
Contributor Author

cjwinsor commented Apr 5, 2024

Handles #1782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Archived in project
Development

No branches or pull requests

1 participant