Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Modal: Close button displays top left if headerText is not provided #2598

Open
2 tasks done
raymondboswel opened this issue Jun 17, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@raymondboswel
Copy link
Contributor

Prerequisites

Describe the issue

The title pretty much sums it up. Since headerText is optional, I wouldn't expect the close 'x' to behave differently, and it is a bit jarring.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

^0.28.0-react18

Priority

Low

What product/project are you using Modus Components for ?

WorksOS / Machine Playback

What is your team/division name ?

CCFS/Weka

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

@raymondboswel raymondboswel added the bug Something is wrong and needs to be addressed label Jun 17, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jun 17, 2024
Copy link

Hello @raymondboswel! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant