Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Side Nav: option to replace click handlers with anchor tags and URLs #2651

Open
2 tasks done
gabriel-piltzer-trimble opened this issue Jun 27, 2024 · 1 comment
Open
2 tasks done
Labels
external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@gabriel-piltzer-trimble
Copy link
Collaborator

Prerequisites

Proposal

Users want to be able to middle mouse click or right click and open in new tab from the navigation. For this to work we need anchor tags with URLs in nav <li>. I propose an optional way to swap the provided click handlers with anchor tags.

Motivation and context

Make the modus side nav more user friendly for opening links.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Prism

What is your team/division name ?

Viewpoint

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

Not yet

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jun 27, 2024
Copy link

Hello @gabriel-piltzer-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant