Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add danger theme color to icon-only buttons & allow color styling of TableRowActions #2661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add danger theme color to icon-only buttons & allow color styling of TableRowActions #2661

wants to merge 1 commit into from

Conversation

Kai-Richardson
Copy link

Description

This PR does several things:

  • Extends the 'danger' color theme to icon-only buttons, as it's a valid ButtonColor for all of the other styles.
  • Adds a prop to TableRowAction that allows you to specify the color of the icon shown.
  • Cleans up the scss to reference the global trimble color variables.
  • Fixes a bug with the Row Action page of the storybook where it was referencing an icon that did not exist.

Closes #2660

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

I worked in and verified behavior in Storybook.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f28838
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/667f44132574070008d1dec4
😎 Deploy Preview https://deploy-preview-2661--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 21 (🔴 down 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Kai-Richardson
Kai-Richardson commented Jun 28, 2024
View reviewed changes
stencil-workspace/storybook/stories/components/modus-table/modus-table.stories.tsx
@@ -981,7 +982,8 @@ RowActions.args = {

{
id: '3',
icon: 'cancel',
icon: 'cancel_circle',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the bug referenced in the PR body. There is no cancel icon. I chose to substutite cancel_circle, but there is also cancel_square if that's desired.

@Kai-Richardson Kai-Richardson changed the title Add 'danger' theme color to icon-only button & allow color styling of TableRowActions Add danger theme color to icon-only buttons & allow color styling of TableRowActions Jun 28, 2024
@cjwinsor
Copy link
Contributor

cjwinsor commented Jul 3, 2024

@Kai-Richardson If you haven't already, can you make sure there is an Aha! submission for this so a review can be made?
https://modus.ideas.aha.io/ideas

This change is outside our available modus guidance so it will need to be reviewed by the design system team.

@Kai-Richardson
Copy link
Author

@Kai-Richardson If you haven't already, can you make sure there is an Aha! submission for this so a review can be made? modus.ideas.aha.io/ideas

This change is outside our available modus guidance so it will need to be reviewed by the design system team.

https://modus.ideas.aha.io/ideas/MOD-I-91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff Awaiting requested review from coliff coliff is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the color of table row action buttons
2 participants
@Kai-Richardson @cjwinsor