Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions vs Property Changes #2674

Open
2 tasks done
kuhnboy opened this issue Jul 3, 2024 · 1 comment
Open
2 tasks done

Actions vs Property Changes #2674

kuhnboy opened this issue Jul 3, 2024 · 1 comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Jul 3, 2024

Prerequisites

Proposal

In most components such as the Navbar, instead of setting properties after render such as showMainMenu there is an action method such as hideMainMenu.

In the Utility Panel, the example suggests using an expanded property and setting it after rendering to control the expanded / collapsed state. Shouldn't this be a method to encapsulate post-render functionality?

Not sure what's the best here but I'm seeing an inconsistency.

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components, Modus Web Components Website (Storybook)

Priority

Low

What product/project are you using Modus Components for ?

Trimble Unity

What is your team/division name ?

O&PS

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

Copy link

github-actions bot commented Jul 3, 2024

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant