Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Retain cell error state even if the focus is changed #2798

Closed
prashanthr6383 opened this issue Aug 21, 2024 · 2 comments · Fixed by #2813
Closed

Table: Retain cell error state even if the focus is changed #2798

prashanthr6383 opened this issue Aug 21, 2024 · 2 comments · Fixed by #2813
Assignees
Labels
external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@prashanthr6383
Copy link
Collaborator

prashanthr6383 commented Aug 21, 2024

In current implementation, the cell error styling and message is only persisted when the cell is in edit mode. If the user clicks away or edits a different cell then the previous cell error border and message is removed. Ideally the error state of the cell should be retained until the user corrects the cell value.

Acceptance Criteria

  • No changes to the existing prop or events
  • Table cell in error state should be identified using red border and a error message if the input is focused.
  • Table cell in error state should only retain the red border if the focus is changed.
Copy link

Hello @prashanthr6383! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 21, 2024
@prashanthr6383 prashanthr6383 self-assigned this Aug 22, 2024
@prashanth-offcl prashanth-offcl changed the title Table: Create tooltip on table level to persist error message Table: Retain cell error state even if the focus is changed Aug 27, 2024
@prashanth-offcl
Copy link
Collaborator

@prashanthr6383 Updated the description and added acceptance criteria as discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: Done
2 participants