Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guidelines for Button Group #656

Closed
2 tasks done
Gnirps00 opened this issue Jun 22, 2023 · 10 comments
Closed
2 tasks done

Add Guidelines for Button Group #656

Gnirps00 opened this issue Jun 22, 2023 · 10 comments
Assignees
Labels
5 modus-approved Modus reviewed and approved feature ready for development.

Comments

@Gnirps00
Copy link

Prerequisites

Proposal

It would be nice if we can have some guideline for toggle buttons, just like in the original react bootstrap.
Also guideline for toggle button of icons is nice to have. Good to have some example, not just apis.

Motivation and context

There is no guideline for toggle buttons in modus page currently. And no instruction how toggle buttons of icons should look like.
To implement these into the products, we need some guideline.

@msankaran0712
Copy link
Collaborator

hey @Gnirps00
At the moment, we are focusing on Modus Web Components as our top priority and putting Modus React Bootstrap in maintenance mode.
Our suggestion would be to transition to Web components. Additionally, if you are interested in contributing to Modus React Bootstrap, please don't hesitate to submit a PR for our review.

@msankaran0712
Copy link
Collaborator

@Gnirps00, did you mean a Dropdown toggle?

If you are unable to find the guidelines you are looking for in the links below, could you kindly contact @soniakaukonen or @egunther39?
https://modus.trimble.com/components/web/dropdowns/,
https://modus.trimble.com/components/web/buttons/styles/

@Gnirps00
Copy link
Author

Hi, thank you for reply.
I mean by toggle button like these buttons in https://react-bootstrap.netlify.app/docs/components/buttons/#checkbox--radio, but the content with only icons.
In my case, I would like to know how the button should look like, if there are 2 options and user can see which option is chosen.
And there no instruction for this toggle button currently.

So, it will likely look like this.
image
Or be completely different, if you have some other instruction for this.

@msankaran0712
Copy link
Collaborator

@soniakaukonen @egunther39 would you like to comment on this ?

@coliff
Copy link
Member

coliff commented Jul 19, 2023

Here's Modus Bootstrap v2 Button group styling:

image

@msankaran0712
Copy link
Collaborator

Maha to create an issue for styleguide, figma and web components

@msankaran0712 msankaran0712 transferred this issue from trimble-oss/modus-react-bootstrap Jul 20, 2023
@msankaran0712 msankaran0712 added the modus-approved Modus reviewed and approved feature ready for development. label Jul 20, 2023
@msankaran0712 msankaran0712 changed the title Guideline for toggle button Add Guidelines for toggle button Jul 20, 2023
@msankaran0712
Copy link
Collaborator

@Gnirps00 We will be adding the guidelines for the toggle buttons group very soon.

@Gnirps00
Copy link
Author

Hi, thank you for updates!

@msankaran0712 msankaran0712 added the 2 label Aug 4, 2023
@soniakaukonen soniakaukonen changed the title Add Guidelines for toggle button Add Guidelines for Button Group Aug 23, 2023
@msankaran0712
Copy link
Collaborator

Wait for Daphnee to add it to Figma

@coliff
Copy link
Member

coliff commented Mar 1, 2024

@coliff coliff closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 modus-approved Modus reviewed and approved feature ready for development.
Projects
None yet
Development

No branches or pull requests

5 participants