Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution-process.md #743

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

soniakaukonen
Copy link
Contributor

@soniakaukonen soniakaukonen commented Oct 25, 2023

Workshop additions and checkbox tables.

https://deploy-preview-743--modus-styleguide.netlify.app/

Workshop additions and checkbox tables.
@soniakaukonen soniakaukonen linked an issue Oct 25, 2023 that may be closed by this pull request
Engineering checklist modified.
Reorganized cards on page.

Upon submission, a Clickup issue is automatically created in the "Submitted" column on the MoAB Board. MoAB meets weekly for reviews and handles incoming submissions. Please, allow five (5) business days for your submission to be reviewed. The submitting party is notified by the MoAB lead once their submission is reviewed.

#### 2.2. Engineering Submission
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly hold on with the Engineering Submission section, I would like @coliff to review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is work in progress, no worries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soniakaukonen I would recommend adding a link to https://github.com/trimble-oss/modus-web-components/blob/main/CONTRIBUTING.md for more details on the contributing guidelines for web components.
@coliff Can we include Modus Bootstrap guidelines too ?

The Modus contribution process is led by the Modus Approval Board (MoAB).

The Modus Approval Board (MoAB) is a cross-organizational team consisting of Senior UX Designers representing a variety of Trimble products in addition to the Modus Delivery Team. MoAB is focused on maintaining, organizing, reviewing, and pushing along component and pattern submissions to Trimble's Modus Design System leading the contribution process.

{{< img src="/img/guide/contribution-process.svg" dark="/img/guide/contribution-process-dark.svg" width="854" height="392" alt="Contribution Process" loading="auto" >}}

### 1. Understanding the design system and the process
Copy link
Collaborator

@msankaran0712 msankaran0712 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a flowchart or a pictorial representation of the process would be really useful. Sometimes people don't spend even 2 mins for reading. I hope we can consider this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msankaran0712 This was planned but we have a resourcing issue to solve.

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for modus-styleguide ready!

Name Link
🔨 Latest commit 35b88d8
🔍 Latest deploy log https://app.netlify.com/sites/modus-styleguide/deploys/6675681b79e10400081cb68b
😎 Deploy Preview https://deploy-preview-743--modus-styleguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@trimble-oss trimble-oss deleted a comment from github-actions bot Jun 21, 2024
@coliff
Copy link
Member

coliff commented Jun 21, 2024

@enowak1031 - what shall we do with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modus Contribution Process Update
3 participants