Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate testBasicTypes into different test methods for different column types #11181

Closed
6 tasks done
tangjiangling opened this issue Feb 24, 2022 · 0 comments
Closed
6 tasks done
Assignees
Labels

Comments

@tangjiangling
Copy link
Member

tangjiangling commented Feb 24, 2022

#11148 (comment)

The testBasicTypes method of the existing connector type mapping tests can be optimized to:

  • Makes the basic types(bigint/int/smallint ...) mapping test method simpler, with one method testing only one type
    • Separate testBasicTypes into different test methods for different column types
  • Improve test coverage per basic types
    • Add min/max/min-1/max+1/null tests for each column type

Here is the list of connectors we need to modify:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants