Improve JDBC connector SQL support section #24523
Open
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As applicable for PostgreSQL connector for now. Also extract into a fragment so it can be reused in other connectors.
mosabua
commented
Dec 18, 2024
| The connector supports adding rows using [MERGE statements](/sql/merge), if the | ||
| `merge.non-transactional-merge.enabled` catalog property or the corresponding | ||
| `non_transactional_merge_enabled` catalog session property is set to | ||
| `true`. Merge is only supported for directly modifying target tables. |
There was a problem hiding this comment.
Not sure this sentence makes sense and takes the original content and captures what was meant @chenjian2664 and @ebyhr
chenjian2664
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks. I was also thought to do this, but forgot :)
Involve @kokosing
| @@ -0,0 +1,10 @@ | |||
| ### Non-transactional MERGE | |||
|
|
|||
| The connector supports adding rows using [MERGE statements](/sql/merge), if the | |||
There was a problem hiding this comment.
The connector supports adding rows using MERGE can add/update/delete rows, maybe you have better phrase? like change adding rows to modifying rows?
|
Phoenix Connector also supports non transactional merge @mosabua |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now this is PostgresSQL connector only. Once I get some feedback that this is good .. I will expand the second commit and do the same changes for all other JDBC connectors.
Additional context and related issues
Follow up to #23034 and related PRs.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.