Fix failures in iceberg cloud tests #24561
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-stec
force-pushed
the
ls/2412/05-fix-iceberg-tests
branch
from
4559d48 to
9e18af1
Compare
|
/test-with-secrets sha=9e18af13e7f8d91fa73d491e162ebca2505cf2b4 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12465571534 |
lukasz-stec
force-pushed
the
ls/2412/05-fix-iceberg-tests
branch
from
9e18af1 to
a1b9d90
Compare
|
added missing @test annotation |
|
/test-with-secrets sha=a1b9d9067fd24eb591015bfcb34874f85aed7663 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12467791284 |
|
Run with secrets is green. |
hashhar
approved these changes
Dec 23, 2024
ebyhr
reviewed
Dec 24, 2024
| public void testIcebergTablesFunction() | ||
| { | ||
| assertThatThrownBy(super::testIcebergTablesFunction) | ||
| .hasMessageContaining("schemaPath is not supported for Iceberg snowflake catalog"); |
There was a problem hiding this comment.
Snowflake catalog supports iceberg_tables function, right? Skipping the entire test doesn't make sense to me. We could run this function without additional schema creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ci failures introduced by #24469
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: