Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repartition writes across nodes when loading data into partitioned table #304

Closed
findepi opened this issue Feb 24, 2019 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@findepi
Copy link
Member

findepi commented Feb 24, 2019

Currently, when Presto INSERTs or CREATE TABLE AS a partitioned table, each node can write to all partitions.
This is good when number of partitions is reasonable, but doesn't play well when loading data into large number of partitions.
Typically, such query will fail with "Too many open files". After bumping file limits, one can run into other issues (too many threads, out of memory, etc.)

We should repartition data so that each partition is written by one node.

  • at first, this can be an opt-int feature (or opt-out? repartitioning is a safer bet)
  • later, we can perhaps smartly choose whether to repartition data or not based at planning time

This issue replaces #579

@findepi findepi added the enhancement New feature or request label Feb 24, 2019
@electrum
Copy link
Member

electrum commented Feb 24, 2019 via email

@sopel39
Copy link
Member

sopel39 commented Dec 28, 2019

I will create a PR that will allow connectors to specify preferred insert partitioning (#2358). There will be a toggle that will allow to enable usage of such partitioning in the engine. In the future we could use CBO for choosing preferred insert partitioning.

@sopel39
Copy link
Member

sopel39 commented Feb 5, 2020

Fixed via: #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants