You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
io.prestosql.sql.query.QueryAssertions#expression(java.lang.String) + matches can pass eveb when value is not correct for given type: eg not properly truncated (char with trailing spaces), or not properly rounded (timestamp with not max precision).
io.prestosql.sql.query.QueryAssertions#expression(java.lang.String)
+matches
can pass eveb when value is not correct for given type: eg not properly truncated (char with trailing spaces), or not properly rounded (timestamp with not max precision).See #5736 (comment) for example.
Implementation plan:
Add checks within (explicitly or implicitly)
io.prestosql.spi.type.Type#getObjectValue
implementations:decimal
scale, precision checkschar
length check, padding spaces stripped check Add char, varchar wellformedness checks #5743varchar
length check Add char, varchar wellformedness checks #5743time
andtime with time zone
precision checkstimestamp
andtimestamp with time zone
precision checks Fix rounding in cast from TIME to TIMESTAMP #5742 (ba17097)The text was updated successfully, but these errors were encountered: