Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shading of org.apache.iceberg:iceberg-core #6092

Closed
sopel39 opened this issue Nov 25, 2020 · 1 comment · Fixed by #8172
Closed

Improve shading of org.apache.iceberg:iceberg-core #6092

sopel39 opened this issue Nov 25, 2020 · 1 comment · Fixed by #8172

Comments

@sopel39
Copy link
Member

sopel39 commented Nov 25, 2020 •
edited
Loading

Currently it doesn't shade some dependencies, like com.github.ben-manes.caffeine:caffeine:2.7.0.
This causes conflicts when dependencies versions are updated in presto root POM (e.g: #6089).
This was referenced Nov 25, 2020
Closed
Merged
@electrum
Copy link
Member

electrum commented Jun 1, 2021

iceberg-core is a normal artifact and doesn't shade any dependencies, which is fine. This is a more general Maven issue that you have to deal with due to how Maven does dependency resolution.

@electrum electrum linked a pull request Jun 2, 2021 that will close this issue
Update to Error Prone 2.7.1 and Jdbi 3.20.0 #8172
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Error Prone 2.7.1 and Jdbi 3.20.0 electrum/trino
2 participants
@electrum @sopel39